chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java - Issue 2669873002: [ImportantSites] Implementing dialog level blacklisting and blacklist expiration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

Issue 2669873002: [ImportantSites] Implementing dialog level blacklisting and blacklist expiration (Closed)

Patch Set: Comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java ('k') | chrome/browser/android/preferences/pref_service_bridge.cc » ('j') | chrome/browser/engagement/important_sites_util.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

index 82b5794fe09fbd57558e3f0db96f5fc04e46ba7a..4cecbcbdd6af4ad3b222fcf37dff6a14961ff158 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/ClearBrowsingDataPreferences.java

@@ -594,9 +594,9 @@ public class ClearBrowsingDataPreferences extends PreferenceFragment

}

@Override

- public void onImportantRegisterableDomainsReady(

- String[] domains, String[] exampleOrigins, int[] importantReasons) {

- if (domains == null) return;

+ public void onImportantRegisterableDomainsReady(String[] domains, String[] exampleOrigins,

+ int[] importantReasons, boolean dialogBlacklisted) {

dominickn 2017/02/03 21:14:51 Nit: dialogDisabled

dmurph 2017/02/04 00:52:25 Done.

+ if (domains == null || dialogBlacklisted) return;

// mMaxImportantSites is a constant on the C++ side. While 0 is valid, use 1 as the minimum

// because histogram code assumes a min >= 1; the underflow bucket will record the 0s.

RecordHistogram.recordLinearCountHistogram("History.ClearBrowsingData.NumImportant",