[ImportantSites] Implementing dialog level blacklisting and blacklist expiration

chrome/common/pref_names.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/pref_names.h"
 
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/common/features.h"
 #include "chrome/common/pref_font_webkit_names.h"
@@ skipping 1324 matching lines @@
 #if !defined(OS_ANDROID)
 // Whether or not this profile has been shown the Welcome page.
 const char kHasSeenWelcomePage[] = "browser.has_seen_welcome_page";
 #endif
 
 #if defined(OS_WIN)
 // Whether or not this profile has been shown the Win10 promo page.
 const char kHasSeenWin10PromoPage[] = "browser.has_seen_win10_promo_page";
 #endif
 
 // *************** LOCAL STATE ***************

[gab, 2017/02/06 20:34:01]

I know it's non-obvious... but profile prefs go above this line... And in fact,
non-ifdefed prefs go above all the if defs blocks above this line (ideally
grouped with related prefs if any but I'm aware it's a mess..)

[dmurph, 2017/02/06 23:34:22]

Done.

 // These are attached to the machine/installation
 
 // Directory of the last profile used.
 const char kProfileLastUsed[] = "profile.last_used";
 
 // List of directories of the profiles last active.
 const char kProfilesLastActive[] = "profile.last_active_profiles";
 
 // Total number of profiles created for this Chrome build. Used to tag profile
 // directories.
@@ skipping 1025 matching lines @@
 // A dictionary which stores whether location access is enabled for the current
 // default search engine, if it is the Google search engine.
 const char kGoogleDSEGeolocationSetting[] = "google_dse_geolocation_setting";
 
 // A dictionary of manifest URLs of Web Share Targets to a dictionary containing
 // attributes of its share_target field found in its manifest. Each key in the
 // dictionary is the name of the attribute, and the value is the corresponding
 // value.
 const char kWebShareVisitedTargets[] = "profile.web_share.visited_targets";
 
+// A dictionary which stores when and how many times the user has ignored the
+// important sites dialog.
+const char kImportantSitesDialogHistory[] = "important_sites.dialog_history";

[gab, 2017/02/06 20:34:01]

"important_sites." is not an existing prefs namespace (i.e. no other
important_sites.* prefs), can we find an existing one that makes sense?
Otherwise we create a JSON dict just for it...

[dmurph, 2017/02/06 23:34:22]

It doesn't look like there's anything else - putting it in a global.

+
 }  // namespace prefs