components/subresource_filter/content/common/subresource_filter_messages.h - Issue 2669833004: Refactor subresource filter activation to support PlzNavigate cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/common/subresource_filter_messages.h

Issue 2669833004: Refactor subresource filter activation to support PlzNavigate cleanly. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/subresource_filter/content/common/document_subresource_filter.h ('k') | components/subresource_filter/content/renderer/subresource_filter_agent.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/common/subresource_filter_messages.h

diff --git a/components/subresource_filter/content/common/subresource_filter_messages.h b/components/subresource_filter/content/common/subresource_filter_messages.h

index 209c684ac6b6caae74d437e366775150539df3a9..84ed28bc51b3526e7e65f3960c37cf1756e5a431 100644

--- a/components/subresource_filter/content/common/subresource_filter_messages.h

+++ b/components/subresource_filter/content/common/subresource_filter_messages.h

@@ -37,13 +37,20 @@ IPC_STRUCT_TRAITS_END()

IPC_MESSAGE_CONTROL1(SubresourceFilterMsg_SetRulesetForProcess,

IPC::PlatformFileForTransit /* ruleset_file */);

-// Instructs the renderer to activate subresource filtering for the currently

-// ongoing provisional document load in a frame. The message must arrive after

-// the provisional load starts, but before it is committed on the renderer side.

+// Instructs the renderer to activate subresource filtering at the specified

+// |activation_level| for the document load committed next in a frame.

+//

+// Without browser-side navigation, the message must arrive just before the

+// provisional load is committed on the renderer side. In practice, it is often

+// sent after the provisional load has already started, but this is not a

+// requirement. The message will have no effect if the provisional load fails.

+//

+// With browser-side navigation enabled, the message must arrive just before

+// FrameMsg_CommitNavigation.

+//

// If no message arrives, the default behavior is ActivationLevel::DISABLED.

-IPC_MESSAGE_ROUTED3(SubresourceFilterMsg_ActivateForProvisionalLoad,

+IPC_MESSAGE_ROUTED2(SubresourceFilterMsg_ActivateForNextCommittedLoad,

subresource_filter::ActivationLevel /* activation_level */,

- GURL /* url */,

bool /* measure_performance */);

// ----------------------------------------------------------------------------