components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h - Issue 2669833004: Refactor subresource filter activation to support PlzNavigate cleanly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

Issue 2669833004: Refactor subresource filter activation to support PlzNavigate cleanly. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/browser/DEPS ('K') | « components/subresource_filter/content/browser/content_subresource_filter_driver.cc ('k') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory.cc » ('j') | components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

index 49727a6ed25226998f872f1f7a53540c4f796b50..588b43611233ffbbe82bed9e5ce93b4dad856491 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory.h

@@ -115,13 +115,15 @@ class ContentSubresourceFilterDriverFactory

// activation signal should be sent.

bool ShouldActivateForMainFrameURL(const GURL& url) const;

void ActivateForFrameHostIfNeeded(content::RenderFrameHost* render_frame_host,

- const GURL& url);

+ const GURL& url,

+ bool failed_navigation);

// Internal implementation of ReadyToCommitNavigation which doesn't use

// NavigationHandle to ease unit tests.

void ReadyToCommitNavigationInternal(

content::RenderFrameHost* render_frame_host,

- const GURL& url);

+ const GURL& url,

+ bool failed_navigation);

bool DidURLMatchCurrentActivationList(const GURL& url) const;