components/subresource_filter/content/browser/DEPS - Issue 2669833004: Refactor subresource filter activation to support PlzNavigate cleanly.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/subresource_filter/content/browser/DEPS

Issue 2669833004: Refactor subresource filter activation to support PlzNavigate cleanly. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+components/keyed_service/core",	2 "+components/keyed_service/core",

	3 "+components/safe_browsing_db",

3 "+content/public/browser",	4 "+content/public/browser",

4 "+components/safe_browsing_db",	5 "+net/base",
	clamy 2017/02/09 10:32:06 Is this because you have to compare the error code Is this because you have to compare the error code of the NavigationHandle to net::OK? engedy 2017/02/09 13:42:01 Yeah. I wasn't sure if it's OK to sneakily just re Show quoted text On 2017/02/09 10:32:06, clamy (slow - catching up) wrote: > Is this because you have to compare the error code of the NavigationHandle to > net::OK? Yeah. I wasn't sure if it's OK to sneakily just rely on transitive includes. clamy 2017/02/09 14:09:42 It's fine, just wanted to check if there was anoth Show quoted text On 2017/02/09 13:42:01, engedy wrote: > On 2017/02/09 10:32:06, clamy (slow - catching up) wrote: > > Is this because you have to compare the error code of the NavigationHandle to > > net::OK? > > Yeah. I wasn't sure if it's OK to sneakily just rely on transitive includes. It's fine, just wanted to check if there was another usage.
5 ]	6 ]

OLD	NEW