Prevent liveedit on or under generators with open activations

Prevent liveedit on or under generators with open activations

R=yangguo@chromium.org
LOG=N
TEST=mjsunit/harmony/generators-debug-liveedit.js
BUG=

Committed: https://code.google.com/p/v8/source/detail?r=21174

[wingo, 2014-05-05 10:56:32]

Related to bug 3289; depends on changes in
https://codereview.chromium.org/260423002/.

[Yang, 2014-05-06 13:05:03]

LGTM with a few nits.
CatGenerator is a really weird identifier...

https://codereview.chromium.org/266983004/diff/1/src/liveedit.cc
File src/liveedit.cc (right):

https://codereview.chromium.org/266983004/diff/1/src/liveedit.cc#newcode1813
src/liveedit.cc:1813: Handle<FixedArray> result, int len) {
one argument per line is easier on the eye.

https://codereview.chromium.org/266983004/diff/1/src/liveedit.cc#newcode1827
src/liveedit.cc:1827: while (((obj = iterator.next()) != NULL)) {
I think we can remove one set of brackets here.

https://codereview.chromium.org/266983004/diff/1/src/liveedit.cc#newcode1900
src/liveedit.cc:1900: if (FindActiveGenerators(shared_info_array_elements,
result_elements, len))
please use curly brackets if the if-statement contains a line break.

https://codereview.chromium.org/266983004/diff/1/test/mjsunit/harmony/generat...
File test/mjsunit/harmony/generators-debug-liveedit.js (right):

https://codereview.chromium.org/266983004/diff/1/test/mjsunit/harmony/generat...
test/mjsunit/harmony/generators-debug-liveedit.js:88: assertThrows(function() {
patch(generator, "'Capybara'", "'Tapir'") }, LiveEdit.Failure);
line break somewhere for the 80-char limit would be nice.

[wingo, 2014-05-06 14:28:09]

Thanks for the review.  LiveEdit is nasty stuff.

On 2014/05/06 13:05:03, Yang wrote:
> CatGenerator is a really weird identifier...

Yeah :/  The whole internal menagerie of liveedit tests is cats and capybaras
and functions that call Function to return fresh functions; it infects the brain
when writing fresh tests.

Anyway I've changed to MakeGenerator and MakeFunction.  Hopefully that's a bit
better.

[wingo, 2014-05-06 14:58:03]

Committed patchset #1 manually as r21174 (presubmit successful).