Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 2669783002: Put tree-shaking behind a flag in dartk. (Closed)

Created:
3 years, 10 months ago by asgerf
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add flag to test.py to disable tree-shaking. #

Patch Set 3 : Make named argument TargetFlags.treeShake default to false #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M pkg/kernel/bin/dartk.dart View 3 chunks +9 lines, -2 lines 0 comments Download
M pkg/kernel/lib/target/targets.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M pkg/kernel/lib/target/vm.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M tools/testing/dart/compiler_configuration.dart View 1 7 chunks +12 lines, -8 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
asgerf
3 years, 10 months ago (2017-02-01 13:15:11 UTC) #2
jensj
lgtm
3 years, 10 months ago (2017-02-01 14:10:22 UTC) #3
asgerf
3 years, 10 months ago (2017-02-02 14:10:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
14c6b275337e1a685d5125fa89e43e3ede3d4320 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698