Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 266973005: Remove RenderFlowThread::initialLogicalWidth(). (Closed)

Created:
6 years, 7 months ago by mstensho (USE GERRIT)
Modified:
6 years, 7 months ago
CC:
blink-reviews, mstensho+blink_opera.com, blink-reviews-rendering, chromiumbugtracker_adobe.com, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove RenderFlowThread::initialLogicalWidth(). Re-implement updateLogicalWidth() in RenderMultiColumnFlowThread instead. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173425

Patch Set 1 #

Patch Set 2 : Rebase master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -13 lines) Patch
M Source/core/rendering/RenderFlowThread.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderFlowThread.cpp View 1 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMultiColumnFlowThread.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-05 14:49:57 UTC) #1
mstensho (USE GERRIT)
6 years, 7 months ago (2014-05-06 07:49:10 UTC) #2
rune
non-owner lgtm
6 years, 7 months ago (2014-05-06 08:45:28 UTC) #3
esprehn
lgtm
6 years, 7 months ago (2014-05-06 17:01:37 UTC) #4
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 7 months ago (2014-05-06 18:46:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/266973005/1
6 years, 7 months ago (2014-05-06 18:46:45 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-06 18:46:52 UTC) #7
commit-bot: I haz the power
Failed to apply patch for Source/core/rendering/RenderMultiColumnFlowThread.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 7 months ago (2014-05-06 18:46:52 UTC) #8
mstensho (USE GERRIT)
The CQ bit was checked by mstensho@opera.com
6 years, 7 months ago (2014-05-06 19:13:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mstensho@opera.com/266973005/20001
6 years, 7 months ago (2014-05-06 19:14:00 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-06 20:23:53 UTC) #11
Message was sent while issue was closed. 
Change committed as 173425

Powered by Google App Engine
This is Rietveld 408576698