Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 266973002: Password bubble: Create subviews for ManagePasswordsBubbleView. (Closed)

Created:
6 years, 7 months ago by Mike West
Modified:
6 years, 7 months ago
Reviewers:
vabr (Chromium)
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Password bubble: Create subviews for ManagePasswordsBubbleView. Same idea as we've done for ManagePasswordItemView: separate subview classes make it simpler to change the content and to understand where the content is coming from. After this CL, it will be a simpler addition to shoehorn in a blacklist confirmation screen in the same way that we've done undo for the item views. ----------------------------------------------------------------------- This is a reland of r267213, which was reverted in order to revert a different patch (r266859) due to LSAN errors. The original review is https://codereview.chromium.org/255903006/ ----------------------------------------------------------------------- BUG=261628 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268179

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+345 lines, -274 lines) Patch
M chrome/browser/ui/passwords/manage_passwords_bubble.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.h View 1 chunk +8 lines, -6 lines 0 comments Download
M chrome/browser/ui/passwords/manage_passwords_bubble_model.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_password_item_view.h View 3 chunks +1 line, -6 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_password_item_view.cc View 4 chunks +39 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.h View 3 chunks +64 lines, -47 lines 0 comments Download
M chrome/browser/ui/views/passwords/manage_passwords_bubble_view.cc View 6 chunks +227 lines, -202 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Mike West
Vaclav, would you mind stamping this reland of a patch that was reverted in order ...
6 years, 7 months ago (2014-05-05 07:10:38 UTC) #1
vabr (Chromium)
Stampity stamp. :) LGTM
6 years, 7 months ago (2014-05-05 07:47:54 UTC) #2
Mike West
The CQ bit was checked by mkwst@chromium.org
6 years, 7 months ago (2014-05-05 13:21:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/266973002/1
6 years, 7 months ago (2014-05-05 13:22:46 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 14:55:16 UTC) #5
Message was sent while issue was closed.
Change committed as 268179

Powered by Google App Engine
This is Rietveld 408576698