Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2669723002: Fix more partially hidden articles (Closed)

Created:
3 years, 10 months ago by wychen
Modified:
3 years, 10 months ago
Reviewers:
mdjones
CC:
noyau (Ping after 24h), lody, gambard, olivierrobin
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix more partially hidden articles When traversing the DOM tree, invisible elements are ignored. In order to correctly handle partially hidden articles on sites having the "continue reading" button, if the class name contains "continue", it would still be processed. BUG=687071 R=mdjones@chromium.org Committed: 6bd2ebbcce6ecfb349c812adcf15ef047aef54a4

Patch Set 1 #

Patch Set 2 : wrap #

Patch Set 3 : don't rely on article #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M java/org/chromium/distiller/webdocument/DomConverter.java View 1 2 1 chunk +8 lines, -2 lines 0 comments Download
M javatests/org/chromium/distiller/webdocument/DomConverterTest.java View 1 3 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
wychen
PTAL
3 years, 10 months ago (2017-02-01 05:02:23 UTC) #2
mdjones
lgtm % update description to include something about white listing "continue"
3 years, 10 months ago (2017-02-01 21:44:54 UTC) #3
wychen
Changed the logic to not be blocked by https://bugs.chromium.org/p/chromium/issues/detail?id=645690.
3 years, 10 months ago (2017-02-02 16:38:54 UTC) #6
mdjones
still lgtm
3 years, 10 months ago (2017-02-02 17:10:53 UTC) #7
wychen
3 years, 10 months ago (2017-02-02 18:01:19 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
6bd2ebbcce6ecfb349c812adcf15ef047aef54a4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698