Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/testing/dart/compiler_configuration.dart

Issue 2669543003: Use the app snapshot when testing with -cdartk. (Closed)
Patch Set: . Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/compiler_configuration.dart
diff --git a/tools/testing/dart/compiler_configuration.dart b/tools/testing/dart/compiler_configuration.dart
index 4b5be7d19e9a3911d971ee5d6734e9be0cda6277..274cb2faacd705cd47b1fe6ff4d5d4eb93496935 100644
--- a/tools/testing/dart/compiler_configuration.dart
+++ b/tools/testing/dart/compiler_configuration.dart
@@ -223,7 +223,7 @@ class NoneCompilerConfiguration extends CompilerConfiguration {
CommandArtifact artifact) {
List<String> args = [];
if (useDFEIsolate) {
- args.add('--dfe=utils/kernel-service/kernel-service.dart');
+ args.add('--dfe=$buildDir/gen/kernel-service.dart.snapshot');
kustermann 2017/02/01 08:48:06 You should do the same in tools/testing/dart/test_
Vyacheslav Egorov (Google) 2017/02/01 08:51:22 That would not work because snapshot versions are
kustermann 2017/02/01 08:56:15 Good point. If it was part of a normal dart sdk,
}
if (isChecked) {
args.add('--enable_asserts');
« no previous file with comments | « tests/language/language.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698