separate state for msaa renderability

separate state for msaa renderability

Committed: http://code.google.com/p/skia/source/detail?r=11770

[robertphillips, 2013-10-14 17:12:04]

https://codereview.chromium.org/26695005/diff/3001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/26695005/diff/3001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:1051: kConfigNames[i],
kNo_MSAA instead of false & kYes_MSAA instead of true?

[bsalomon, 2013-10-14 17:14:06]

https://codereview.chromium.org/26695005/diff/3001/src/gpu/GrDrawTarget.cpp
File src/gpu/GrDrawTarget.cpp (right):

https://codereview.chromium.org/26695005/diff/3001/src/gpu/GrDrawTarget.cpp#n...
src/gpu/GrDrawTarget.cpp:1051: kConfigNames[i],
On 2013/10/14 17:12:04, robertphillips wrote:
> kNo_MSAA instead of false & kYes_MSAA instead of true?

That enum is defined locally only in GrGLCaps::init...()

Originally I made it a public member of GrDrawTargetCaps and made the interface
take it instead of a bool. But it made the call sites really ugly.

[bsalomon, 2013-10-14 19:24:16]

changed [false],[true] to [0],[1]

[commit-bot: I haz the power, 2013-10-15 14:07:48]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[brian1, 2013-10-15 14:08:41]

Rob gave me a verbal lgtm.

[commit-bot: I haz the power, 2013-10-15 14:08:58]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/bsalomon@google.com/26695005/9001

[commit-bot: I haz the power, 2013-10-15 14:18:27]

Change committed as 11770

[robertphillips, 2013-10-15 15:04:20]

Doh - here is a posthumous lgtm.