Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sdk/lib/collection/list.dart

Issue 26695002: Growable typed data buffers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pkg/collection_helpers/test/typed_buffers_test.dart ('K') | « pkg/collection_helpers/test/typed_buffers_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/collection/list.dart
diff --git a/sdk/lib/collection/list.dart b/sdk/lib/collection/list.dart
index eed6b32cefb5966d4803b52e881d8b85e1401697..a22da23beb4a8ef700ebcc37e7673c779b2acd00 100644
--- a/sdk/lib/collection/list.dart
+++ b/sdk/lib/collection/list.dart
@@ -462,6 +462,8 @@ abstract class ListMixin<E> implements List<E> {
throw new RangeError.range(index, 0, length);
}
// TODO(floitsch): we can probably detect more cases.
+ // TODO(lrn): How about having a marker interface that promises that length
floitsch 2013/10/15 15:28:05 That should be done now.
+ // is efficient? List implements EfficientLength.
if (iterable is! List && iterable is! Set && iterable is! SubListIterable) {
iterable = iterable.toList();
}
« pkg/collection_helpers/test/typed_buffers_test.dart ('K') | « pkg/collection_helpers/test/typed_buffers_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698