Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: third_party/WebKit/Source/core/style/ComputedStyle.h

Issue 2669433002: Moved table-layout property to be generated in ComputedStyleBase. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/style/ComputedStyle.h
diff --git a/third_party/WebKit/Source/core/style/ComputedStyle.h b/third_party/WebKit/Source/core/style/ComputedStyle.h
index e61d0e02b7fec15a91864167a78821acc9acf51a..69fdc91e8225d5f52c438706d1ccff2af3e457eb 100644
--- a/third_party/WebKit/Source/core/style/ComputedStyle.h
+++ b/third_party/WebKit/Source/core/style/ComputedStyle.h
@@ -227,7 +227,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
m_overflowY == other.m_overflowY &&
m_verticalAlign == other.m_verticalAlign &&
m_clear == other.m_clear && m_position == other.m_position &&
- m_tableLayout == other.m_tableLayout &&
Bugs Nash 2017/01/31 19:49:47 could we add some comment to the code that indicat
shend 2017/01/31 22:03:39 Good idea! I get confused sometimes as well. Done.
// hasViewportUnits
m_breakBefore == other.m_breakBefore &&
m_breakAfter == other.m_breakAfter &&
@@ -257,7 +256,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
unsigned m_verticalAlign : 4; // EVerticalAlign
unsigned m_clear : 2; // EClear
unsigned m_position : 3; // EPosition
- unsigned m_tableLayout : 1; // ETableLayout
// This is set if we used viewport units when resolving a length.
// It is mutable so we can pass around const ComputedStyles to resolve
@@ -315,8 +313,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
static_cast<unsigned>(initialVerticalAlign());
m_nonInheritedData.m_clear = initialClear();
m_nonInheritedData.m_position = initialPosition();
- m_nonInheritedData.m_tableLayout =
- static_cast<unsigned>(initialTableLayout());
m_nonInheritedData.m_breakBefore = initialBreakBefore();
m_nonInheritedData.m_breakAfter = initialBreakAfter();
m_nonInheritedData.m_breakInside = initialBreakInside();
@@ -1779,14 +1775,6 @@ class CORE_EXPORT ComputedStyle : public ComputedStyleBase,
void setPageSizeType(PageSizeType t) {
SET_VAR(m_rareNonInheritedData, m_pageSizeType, t);
}
- // table-layout
- static ETableLayout initialTableLayout() { return ETableLayout::kAuto; }
- ETableLayout tableLayout() const {
- return static_cast<ETableLayout>(m_nonInheritedData.m_tableLayout);
- }
- void setTableLayout(ETableLayout v) {
- m_nonInheritedData.m_tableLayout = static_cast<unsigned>(v);
- }
// Text decoration properties.
// text-decoration-line
« no previous file with comments | « third_party/WebKit/Source/core/css/CSSProperties.json5 ('k') | third_party/WebKit/Source/core/style/ComputedStyle.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698