Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: third_party/WebKit/Source/core/style/ComputedStyleConstants.h

Issue 2669433002: Moved table-layout property to be generated in ComputedStyleBase. (Closed)
Patch Set: Address comments on comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
6 * reserved. 6 * reserved.
7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 7 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * 10 *
(...skipping 15 matching lines...) Expand all
26 */ 26 */
27 27
28 #ifndef ComputedStyleConstants_h 28 #ifndef ComputedStyleConstants_h
29 #define ComputedStyleConstants_h 29 #define ComputedStyleConstants_h
30 30
31 #include "core/ComputedStyleBaseConstants.h" 31 #include "core/ComputedStyleBaseConstants.h"
32 #include <cstddef> 32 #include <cstddef>
33 33
34 namespace blink { 34 namespace blink {
35 35
36 // Some properties are automatically generated in ComputedStyleBase
sashab 2017/02/01 18:16:08 properties -> enums
shend 2017/02/01 21:33:32 done.
37
36 // TODO(sashab): Change these enums to enum classes with an unsigned underlying 38 // TODO(sashab): Change these enums to enum classes with an unsigned underlying
37 // type. Enum classes provide better type safety, and forcing an unsigned 39 // type. Enum classes provide better type safety, and forcing an unsigned
38 // underlying type prevents msvc from interpreting enums as negative numbers. 40 // underlying type prevents msvc from interpreting enums as negative numbers.
39 // See: crbug.com/628043 41 // See: crbug.com/628043
40 42
41 // Sides used when drawing borders and outlines. The values should run clockwise 43 // Sides used when drawing borders and outlines. The values should run clockwise
42 // from top. 44 // from top.
43 enum BoxSide { BSTop, BSRight, BSBottom, BSLeft }; 45 enum BoxSide { BSTop, BSRight, BSBottom, BSLeft };
44 46
45 // See core/dom/stylerecalc.md for an explanation on what each state means 47 // See core/dom/stylerecalc.md for an explanation on what each state means
(...skipping 116 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 Sub, 164 Sub,
163 Super, 165 Super,
164 TextTop, 166 TextTop,
165 TextBottom, 167 TextBottom,
166 Top, 168 Top,
167 Bottom, 169 Bottom,
168 BaselineMiddle, 170 BaselineMiddle,
169 Length 171 Length
170 }; 172 };
171 173
172 enum class ETableLayout : unsigned { kAuto, kFixed };
173
174 enum TextCombine { TextCombineNone, TextCombineAll }; 174 enum TextCombine { TextCombineNone, TextCombineAll };
175 175
176 enum EFillAttachment { 176 enum EFillAttachment {
177 ScrollBackgroundAttachment, 177 ScrollBackgroundAttachment,
178 LocalBackgroundAttachment, 178 LocalBackgroundAttachment,
179 FixedBackgroundAttachment 179 FixedBackgroundAttachment
180 }; 180 };
181 181
182 enum EFillBox { BorderFillBox, PaddingFillBox, ContentFillBox, TextFillBox }; 182 enum EFillBox { BorderFillBox, PaddingFillBox, ContentFillBox, TextFillBox };
183 183
(...skipping 425 matching lines...) Expand 10 before | Expand all | Expand 10 after
609 ScrollSnapTypeNone, 609 ScrollSnapTypeNone,
610 ScrollSnapTypeMandatory, 610 ScrollSnapTypeMandatory,
611 ScrollSnapTypeProximity 611 ScrollSnapTypeProximity
612 }; 612 };
613 613
614 enum AutoRepeatType { NoAutoRepeat, AutoFill, AutoFit }; 614 enum AutoRepeatType { NoAutoRepeat, AutoFill, AutoFit };
615 615
616 } // namespace blink 616 } // namespace blink
617 617
618 #endif // ComputedStyleConstants_h 618 #endif // ComputedStyleConstants_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/style/ComputedStyle.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698