Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1594)

Unified Diff: net/quic/chromium/crypto/proof_verifier_chromium.cc

Issue 2669403004: Allow QUIC to honor SCTs delivered in X509 certificates. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/tools/quic/quic_client_bin.cc » ('j') | net/tools/quic/quic_client_bin.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/chromium/crypto/proof_verifier_chromium.cc
diff --git a/net/quic/chromium/crypto/proof_verifier_chromium.cc b/net/quic/chromium/crypto/proof_verifier_chromium.cc
index 35503e60776c9475c2e53801585dabd146ffde26..eed307d6c8fc5f8eb6d1c48df4c9655d61bc6489 100644
--- a/net/quic/chromium/crypto/proof_verifier_chromium.cc
+++ b/net/quic/chromium/crypto/proof_verifier_chromium.cc
@@ -225,14 +225,12 @@ QuicAsyncStatus ProofVerifierChromium::Job::VerifyProof(
if (!GetX509Certificate(certs, error_details, verify_details))
return QUIC_FAILURE;
- if (!cert_sct.empty()) {
- // Note that this is a completely synchronous operation: The CT Log Verifier
- // gets all the data it needs for SCT verification and does not do any
- // external communication.
- cert_transparency_verifier_->Verify(cert_.get(), std::string(), cert_sct,
- &verify_details_->ct_verify_result.scts,
- net_log_);
- }
+ // Note that this is a completely synchronous operation: The CT Log Verifier
+ // gets all the data it needs for SCT verification and does not do any
+ // external communication.
+ cert_transparency_verifier_->Verify(cert_.get(), std::string(), cert_sct,
+ &verify_details_->ct_verify_result.scts,
+ net_log_);
// We call VerifySignature first to avoid copying of server_config and
// signature.
« no previous file with comments | « no previous file | net/tools/quic/quic_client_bin.cc » ('j') | net/tools/quic/quic_client_bin.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698