Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1622)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/compiler/BUILD.gn

Issue 2669373002: Revert of Allow using goma on Windows with symbol_level == 2 (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/compiler/BUILD.gn
diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn
index 9202fd0abff3024778867f35b607ea9543e71864..9d651ad27157f85f6aa0d723bf677abf284e614a 100644
--- a/build/config/compiler/BUILD.gn
+++ b/build/config/compiler/BUILD.gn
@@ -1580,12 +1580,7 @@
# Full symbols.
config("symbols") {
if (is_win) {
- if (use_goma) {
- # Note that this requires is_win_fastlink, enforced elsewhere.
- cflags = [ "/Z7" ] # Debug information in the .obj files.
- } else {
- cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
- }
+ cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
if (is_win_fastlink) {
# Tell VS 2015+ to create a PDB that references debug
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698