Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 2669363004: Set fileUri when creating library builders. (Closed)

Created:
3 years, 10 months ago by ahe
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Project:
Fasta
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -28 lines) Patch
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_loader.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_target.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 2 chunks +5 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 chunk +20 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 chunk +3 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/target_implementation.dart View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 7 (3 generated)
ahe
3 years, 10 months ago (2017-02-03 20:22:50 UTC) #3
Siggi Cherem (dart-lang)
lgym
3 years, 10 months ago (2017-02-03 20:27:33 UTC) #4
Siggi Cherem (dart-lang)
lgtm
3 years, 10 months ago (2017-02-03 20:27:45 UTC) #5
ahe
3 years, 10 months ago (2017-02-06 10:22:42 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as
15b143e0e898b882a8c038ac72d396bdc9efe68e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698