Support for modular mixin resolution.

Support for modular mixin resolution.

When a class from a different build unit is mixed in, the instance
members of the mixed-in class are retained in the external library
definition, so the mixin resolution pass can clone them.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/ac3e8cb7b3af6a4d866e9a1ebc62b58aefd06c25

[asgerf, 2017-02-02 19:09:47]

asgerf@google.com changed reviewers:
+ kmillikin@google.com

[Kevin Millikin (Google), 2017-02-09 10:44:34]

Yes, LGTM with the comments addressed.

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/binary.md
File pkg/kernel/binary.md (right):

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/binary.md#ne...
pkg/kernel/binary.md:200: Byte flags (isAbstract, xx); // where xx is index of
class level
This should be spelled out explicitly here, even if it's redundant with
ast.dart.

The comment above also mentions only three levels, ast.dart includes five, and
it's ambiguous which index we're talking about.  I guess I'd rather have
something like:

enum ClassLevel { Type = 0, Hierarchy = 1, Mixin = 2, Body = 3, }

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/lib/binary/a...
File pkg/kernel/lib/binary/ast_from_binary.dart (right):

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/lib/binary/a...
pkg/kernel/lib/binary/ast_from_binary.dart:328: node.level =
ClassLevel.values[levelIndex];
Isn't this levelIndex + 1?

[asgerf, 2017-02-13 12:43:36]

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/binary.md
File pkg/kernel/binary.md (right):

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/binary.md#ne...
pkg/kernel/binary.md:200: Byte flags (isAbstract, xx); // where xx is index of
class level
On 2017/02/09 10:44:34, Kevin Millikin (Google) wrote:
> This should be spelled out explicitly here, even if it's redundant with
> ast.dart.
> 
> The comment above also mentions only three levels, ast.dart includes five, and
> it's ambiguous which index we're talking about.  I guess I'd rather have
> something like:
> 
> enum ClassLevel { Type = 0, Hierarchy = 1, Mixin = 2, Body = 3, }

Done.

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/lib/binary/a...
File pkg/kernel/lib/binary/ast_from_binary.dart (right):

https://codereview.chromium.org/2669303002/diff/20001/pkg/kernel/lib/binary/a...
pkg/kernel/lib/binary/ast_from_binary.dart:328: node.level =
ClassLevel.values[levelIndex];
On 2017/02/09 10:44:34, Kevin Millikin (Google) wrote:
> Isn't this levelIndex + 1?

You are right, thanks.

[asgerf, 2017-02-13 13:20:12]

Description was changed from

==========
Support for modular mixin resolution.

When a class from a different build unit is mixed in, the instance
members of the mixed-in class are retained in the external library
definition, so the mixin resolution pass can clone them.

BUG=
==========

to

==========
Support for modular mixin resolution.

When a class from a different build unit is mixed in, the instance
members of the mixed-in class are retained in the external library
definition, so the mixin resolution pass can clone them.

BUG=
R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ac3e8cb7b3af6a4d866e9a1ebc62b58aefd06c25
==========

[asgerf, 2017-02-13 13:20:14]

Committed patchset #5 (id:80001) manually as
ac3e8cb7b3af6a4d866e9a1ebc62b58aefd06c25 (presubmit successful).