Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 26693003: Make HTMLOutputElement.htmlFor settable (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
CC:
blink-reviews, dglazkov+blink, Inactive, adamk+blink_chromium.org
Visibility:
Public.

Description

Make HTMLOutputElement.htmlFor settable Make HTMLOutputElement.htmlFor settable as per the specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-button-element.html#the-output-element Calling HTMLOutputElement.htmlFor="foo" should be equivalent to HTMLOutputElement.value.htmlFor="foo". This behavior is consistent with Firefox 23. BUG=308034 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159838

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M LayoutTests/fast/dom/HTMLOutputElement/dom-settable-token-list-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/fast/dom/HTMLOutputElement/script-tests/dom-settable-token-list.js View 1 chunk +5 lines, -2 lines 0 comments Download
M Source/core/html/HTMLOutputElement.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Inactive
7 years, 2 months ago (2013-10-16 14:06:36 UTC) #1
haraken
LGTM. Needs an approval from an API owner.
7 years, 2 months ago (2013-10-16 15:01:13 UTC) #2
tkent
lgtm
7 years, 2 months ago (2013-10-16 21:46:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26693003/1
7 years, 2 months ago (2013-10-16 21:52:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26693003/1
7 years, 2 months ago (2013-10-17 01:29:55 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 08:17:21 UTC) #6
Message was sent while issue was closed.
Change committed as 159838

Powered by Google App Engine
This is Rietveld 408576698