Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Unified Diff: net/spdy/spdy_session.cc

Issue 2669263002: Add missing case in MapFramerErrorToNetError (SpdyFramer::SPDY_OVERSIZED_PAYLOAD) (Closed)
Patch Set: Merge with master changes. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/spdy/spdy_session_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index fd9650fc9e09bd13d9a68e51b19ea837420c4341..71534c72c95a35234e132c100bf7b54dc5cf6404 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -406,10 +406,11 @@ SpdyProtocolErrorDetails MapFramerErrorToProtocolError(
return SPDY_ERROR_INVALID_CONTROL_FRAME_SIZE;
case SpdyFramer::SPDY_OVERSIZED_PAYLOAD:
return SPDY_ERROR_OVERSIZED_PAYLOAD;
- default:
+ case SpdyFramer::LAST_ERROR:
NOTREACHED();
- return static_cast<SpdyProtocolErrorDetails>(-1);
}
+ NOTREACHED();
+ return static_cast<SpdyProtocolErrorDetails>(-1);
}
Error MapFramerErrorToNetError(SpdyFramer::SpdyFramerError err) {
@@ -446,10 +447,13 @@ Error MapFramerErrorToNetError(SpdyFramer::SpdyFramerError err) {
return ERR_SPDY_FRAME_SIZE_ERROR;
case SpdyFramer::SPDY_INVALID_STREAM_ID:
return ERR_SPDY_PROTOCOL_ERROR;
- default:
+ case SpdyFramer::SPDY_OVERSIZED_PAYLOAD:
+ return ERR_SPDY_FRAME_SIZE_ERROR;
+ case SpdyFramer::LAST_ERROR:
NOTREACHED();
- return ERR_SPDY_PROTOCOL_ERROR;
}
+ NOTREACHED();
+ return ERR_SPDY_PROTOCOL_ERROR;
}
SpdyProtocolErrorDetails MapRstStreamStatusToProtocolError(
@@ -483,10 +487,9 @@ SpdyProtocolErrorDetails MapRstStreamStatusToProtocolError(
return STATUS_CODE_INADEQUATE_SECURITY;
case ERROR_CODE_HTTP_1_1_REQUIRED:
return STATUS_CODE_HTTP_1_1_REQUIRED;
- default:
- NOTREACHED();
- return static_cast<SpdyProtocolErrorDetails>(-1);
}
+ NOTREACHED();
+ return static_cast<SpdyProtocolErrorDetails>(-1);
}
SpdyErrorCode MapNetErrorToGoAwayStatus(Error err) {
« no previous file with comments | « no previous file | net/spdy/spdy_session_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698