Add missing case in MapFramerErrorToNetError (SpdyFramer::SPDY_OVERSIZED_PAYLOAD)

net/spdy/spdy_session.cc

Index: net/spdy/spdy_session.cc
diff --git a/net/spdy/spdy_session.cc b/net/spdy/spdy_session.cc
index a7287cdecf96f9740a1e0e9f89c7f8de61049758..ad972af0e21ed9c7bc9d0178ee18ca81feb5c812 100644
--- a/net/spdy/spdy_session.cc
+++ b/net/spdy/spdy_session.cc
@@ -446,6 +446,8 @@ Error MapFramerErrorToNetError(SpdyFramer::SpdyFramerError err) {
       return ERR_SPDY_FRAME_SIZE_ERROR;
     case SpdyFramer::SPDY_INVALID_STREAM_ID:
       return ERR_SPDY_PROTOCOL_ERROR;
+    case SpdyFramer::SPDY_OVERSIZED_PAYLOAD:
+      return ERR_SPDY_FRAME_SIZE_ERROR;
     default:

[mmenke, 2017/02/02 17:24:31]

Suggest removing the default case from these - that will turn the NOTREACHED()
into a compile time error instead, though I defer to Bence on this.

[Bence, 2017/02/02 20:32:24]

Yes please.  switch() without default case will make the compiler enforce that
all values are handled.

Of course you need to move the default case to after the switch(), because the
function must return something for invalid values (e.g. when called with
static_cast<SpdyFramerError>(1337)).

[Maks Orlovich, 2017/02/02 21:10:14]

Likewise.

       NOTREACHED();
       return ERR_SPDY_PROTOCOL_ERROR;