Add missing case in MapFramerErrorToNetError (SpdyFramer::SPDY_OVERSIZED_PAYLOAD)

net/spdy/spdy_session.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/spdy/spdy_session.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <utility>
@@ skipping 388 matching lines @@
     case SpdyFramer::SPDY_INVALID_CONTROL_FRAME_FLAGS:
       return SPDY_ERROR_INVALID_CONTROL_FRAME_FLAGS;
     case SpdyFramer::SPDY_UNEXPECTED_FRAME:
       return SPDY_ERROR_UNEXPECTED_FRAME;
     case SpdyFramer::SPDY_INTERNAL_FRAMER_ERROR:
       return SPDY_ERROR_INTERNAL_FRAMER_ERROR;
     case SpdyFramer::SPDY_INVALID_CONTROL_FRAME_SIZE:
       return SPDY_ERROR_INVALID_CONTROL_FRAME_SIZE;
     case SpdyFramer::SPDY_OVERSIZED_PAYLOAD:
       return SPDY_ERROR_OVERSIZED_PAYLOAD;
-    default:
+    case SpdyFramer::LAST_ERROR:
       NOTREACHED();
-      return static_cast<SpdyProtocolErrorDetails>(-1);
   }
+  return static_cast<SpdyProtocolErrorDetails>(-1);

[Bence, 2017/02/02 23:19:12]

Did you not want to add NOTREACHED() right above this line, to catch values
greater than LAST_ERROR which are also invalid?  Same for the other two
functions below.

 }
 
 Error MapFramerErrorToNetError(SpdyFramer::SpdyFramerError err) {
   switch (err) {
     case SpdyFramer::SPDY_NO_ERROR:
       return OK;
     case SpdyFramer::SPDY_INVALID_CONTROL_FRAME:
       return ERR_SPDY_PROTOCOL_ERROR;
     case SpdyFramer::SPDY_CONTROL_PAYLOAD_TOO_LARGE:
       return ERR_SPDY_FRAME_SIZE_ERROR;
@@ skipping 16 matching lines @@
     case SpdyFramer::SPDY_INVALID_CONTROL_FRAME_FLAGS:
       return ERR_SPDY_PROTOCOL_ERROR;
     case SpdyFramer::SPDY_UNEXPECTED_FRAME:
       return ERR_SPDY_PROTOCOL_ERROR;
     case SpdyFramer::SPDY_INTERNAL_FRAMER_ERROR:
       return ERR_SPDY_PROTOCOL_ERROR;
     case SpdyFramer::SPDY_INVALID_CONTROL_FRAME_SIZE:
       return ERR_SPDY_FRAME_SIZE_ERROR;
     case SpdyFramer::SPDY_INVALID_STREAM_ID:
       return ERR_SPDY_PROTOCOL_ERROR;
-    default:
+    case SpdyFramer::SPDY_OVERSIZED_PAYLOAD:
+      return ERR_SPDY_FRAME_SIZE_ERROR;
+    case SpdyFramer::LAST_ERROR:
       NOTREACHED();
-      return ERR_SPDY_PROTOCOL_ERROR;
   }
+  return ERR_SPDY_PROTOCOL_ERROR;
 }
 
 SpdyProtocolErrorDetails MapRstStreamStatusToProtocolError(
     SpdyRstStreamStatus status) {
   switch (status) {
     case RST_STREAM_NO_ERROR:
       return STATUS_CODE_NO_ERROR;
     case RST_STREAM_PROTOCOL_ERROR:
       return STATUS_CODE_PROTOCOL_ERROR;
     case RST_STREAM_INTERNAL_ERROR:
@@ skipping 13 matching lines @@
     case RST_STREAM_COMPRESSION_ERROR:
       return STATUS_CODE_COMPRESSION_ERROR;
     case RST_STREAM_CONNECT_ERROR:
       return STATUS_CODE_CONNECT_ERROR;
     case RST_STREAM_ENHANCE_YOUR_CALM:
       return STATUS_CODE_ENHANCE_YOUR_CALM;
     case RST_STREAM_INADEQUATE_SECURITY:
       return STATUS_CODE_INADEQUATE_SECURITY;
     case RST_STREAM_HTTP_1_1_REQUIRED:
       return STATUS_CODE_HTTP_1_1_REQUIRED;
-    default:
+    case RST_STREAM_NUM_STATUS_CODES:
       NOTREACHED();
-      return static_cast<SpdyProtocolErrorDetails>(-1);
   }
+  return static_cast<SpdyProtocolErrorDetails>(-1);
 }
 
 SpdyGoAwayStatus MapNetErrorToGoAwayStatus(Error err) {
   switch (err) {
     case OK:
       return GOAWAY_NO_ERROR;
     case ERR_SPDY_PROTOCOL_ERROR:
       return GOAWAY_PROTOCOL_ERROR;
     case ERR_SPDY_FLOW_CONTROL_ERROR:
       return GOAWAY_FLOW_CONTROL_ERROR;
@@ skipping 2619 matching lines @@
     if (!queue->empty()) {
       SpdyStreamId stream_id = queue->front();
       queue->pop_front();
       return stream_id;
     }
   }
   return 0;
 }
 
 }  // namespace net