third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl - Issue 2669243009: Added CSSPropertyAPIMethods.json5 which defines all API methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl

Issue 2669243009: Added CSSPropertyAPIMethods.json5 which defines all API methods. (Closed)

Patch Set: added comments, renamed variables Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/build/scripts/make_css_property_apis.py ('K') | « third_party/WebKit/Source/build/scripts/templates/CSSPropertyAPIFiles.h.tmpl ('k') | third_party/WebKit/Source/core/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl

index 0cc67d6d5b89221417b0503fc38658112617126a..bf64cae615521a2584f1ba787650c52c98978e43 100644

--- a/third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/CSSPropertyDescriptor.cpp.tmpl

@@ -16,17 +16,19 @@ static_assert(

static CSSPropertyDescriptor cssPropertyDescriptors[] = {

// An invalid CSSPropertyDescriptor.

{

- {% for valid_api_method in valid_api_methods %}

+ {% for api_method in ordered_api_method_names %}

nullptr,

{% endfor %}

// CSSPropertyDescriptors for all valid properties.

{% for api_class in api_classes %}

{

- {% for api_method in api_methods if api_method in api_class.api_methods %}

- {{api_class.classname}}::{{api_method}},

+ {% for api_method_name in ordered_api_method_names %}

+ {% if api_method_name in api_class.methods_for_class %}

+ {{api_class.classname}}::{{api_method_name}},

{% else %}

nullptr,

+ {% endif %}

{% endfor %}