components/DEPS - Issue 266923008: Adjust the structure of DEPS within //components.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/DEPS

Issue 266923008: Adjust the structure of DEPS within //components. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Some nits Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 # Do not add chrome/ as an allowed include.	2 # Do not add chrome/ as an allowed include.

3	3

4 # Individual components must explicitly declare their dependencies	4 # Individual components must explicitly declare their dependencies

5 # on other components. Cycles in the dependency graph within	5 # on other components. Cycles in the dependency graph within

6 # components/ are not allowed.	6 # components/ are not allowed.

7 "-components",	7 "-components",

8	8

9 # Components should only depend on the public Content API, and on	9 # Components that wish to use the content API or IPC must explicitly declare

10 # layers below the Content Module. They must not depend on the	10 # these dependencies; see ./README.

11 # implementation of the Content Module.	11 "-ipc",

12 #

13 # Subdirectories of e.g. src/components/component_name should add

14 # the additional parts of the Content API that they need,

15 # e.g. components/component_name/browser/DEPS would add a

16 # "+content/public/browser" rule.

17 "+content/public/common",

18

19 # Dependencies of variations component.

20 "+third_party/mt19937ar",

21 ]	12 ]

OLD	NEW

« no previous file with comments | « no previous file | components/README » ('j') | components/bookmarks/DEPS » ('J')