Adjust the structure of DEPS within //components.

Adjust the structure of DEPS within //components.

As the majority of components are now shared by iOS, it no longer makes sense
to have a blanket allowance of IPC and //content/public/common in
//components.  Instead, individual components should have to add these
dependencies explicitly, lessening the chance that bad dependencies creep in
(e.g., a //content/public/common dependency in code that iOS shares).

TBR=darin

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=268513

[jochen (gone - plz use gerrit), 2014-05-06 11:45:49]

lgtm but why not keep the comments?

https://codereview.chromium.org/266923008/diff/20001/components/bookmarks/DEPS
File components/bookmarks/DEPS (left):

https://codereview.chromium.org/266923008/diff/20001/components/bookmarks/DEP...
components/bookmarks/DEPS:3: # can be shared on iOS.
maybe keep comment?

https://codereview.chromium.org/266923008/diff/20001/components/data_reductio...
File components/data_reduction_proxy/DEPS (left):

https://codereview.chromium.org/266923008/diff/20001/components/data_reductio...
components/data_reduction_proxy/DEPS:5: # Data reduction proxy is used by iOS,
which does not use content.
and here?

[blundell, 2014-05-06 11:47:51]

Yeah, I couldn't decide about the comments. In general we don't put comments on
every DEPS rule (or lack thereof) in Chromium, and I'm not sure it will make
sense to keep documenting which components are used on iOS in the DEPS files
going forward forever. components.gyp tells you that in a self-documenting way.
After this lands, I'm planning on sending out a PSA to chromium-dev@ and
instructing //content and //ipc OWNERS to carefully vet DEPS additions in
//components. WDYT?

[blundell, 2014-05-06 14:01:59]

I'm going to go ahead and commit this and think some more about the comments
issue.

[blundell, 2014-05-06 14:02:03]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-06 14:02:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/266923008/20001

[commit-bot: I haz the power, 2014-05-06 14:16:15]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium

[commit-bot: I haz the power, 2014-05-06 14:18:34]

FYI, CQ is re-trying this CL (attempt #2).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  chromium_presubmit on tryserver.chromium

[blundell, 2014-05-06 14:22:42]

The CQ bit was unchecked by blundell@chromium.org

[blundell, 2014-05-06 14:23:37]

TBR=darin for addition of "+ipc" into various individual components' DEPS files
following the "-ipc" added to //components/DEPS.

[blundell, 2014-05-06 14:23:42]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2014-05-06 14:23:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/blundell@chromium.org/266923008/20001

[commit-bot: I haz the power, 2014-05-06 14:34:58]

Change committed as 268513