Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 266923005: Remove HTMLAnchorElement::create overload (Closed)

Created:
6 years, 7 months ago by rwlbuis
Modified:
6 years, 7 months ago
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Remove HTMLAnchorElement::create overload This overload is not needed since we always call the other create(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173335

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M Source/core/html/HTMLAnchorElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/HTMLAnchorElement.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rwlbuis
PTAL, it seems this method is not needed.
6 years, 7 months ago (2014-05-05 18:19:09 UTC) #1
adamk
lgtm, I wonder when the caller got deleted
6 years, 7 months ago (2014-05-05 18:32:18 UTC) #2
rwlbuis
The CQ bit was checked by rob.buis@samsung.com
6 years, 7 months ago (2014-05-05 18:32:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rob.buis@samsung.com/266923005/1
6 years, 7 months ago (2014-05-05 18:33:21 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-05 19:42:39 UTC) #5
Message was sent while issue was closed.
Change committed as 173335

Powered by Google App Engine
This is Rietveld 408576698