Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2669223003: Change the DevFS base path (Closed)

Created:
3 years, 10 months ago by Cutch
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change the DevFS base path - [x] Append the file system name as a child directory. This gives a common suffix for source paths. BUG= R=turnidge@google.com Committed: https://github.com/dart-lang/sdk/commit/7a20e49a380fbebb0d421c57904107221803347f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M runtime/bin/vmservice/vmservice_io.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 7 (4 generated)
Cutch
3 years, 10 months ago (2017-02-02 15:32:01 UTC) #3
turnidge
lgtm
3 years, 10 months ago (2017-02-02 20:57:46 UTC) #5
Cutch
3 years, 10 months ago (2017-02-02 20:58:36 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7a20e49a380fbebb0d421c57904107221803347f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698