Remove spelling markers in disabled and readonly form elements

third_party/WebKit/Source/core/html/HTMLElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
  * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
  * (http://www.torchmobile.com/)
  * Copyright (C) 2011 Motorola Mobility. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 412 matching lines @@
 void HTMLElement::attributeChanged(const AttributeModificationParams& params) {
   Element::attributeChanged(params);
   if (params.reason != AttributeModificationReason::kDirectly)
     return;
   // adjustedFocusedElementInTreeScope() is not trivial. We should check
   // attribute names, then call adjustedFocusedElementInTreeScope().
   if (params.name == hiddenAttr && !params.newValue.isNull()) {
     if (adjustedFocusedElementInTreeScope() == this)
       blur();
   } else if (params.name == contenteditableAttr) {
-    if (document().frame()) {
-      document().frame()->spellChecker().removeSpellingAndGrammarMarkers(
-          *this, SpellChecker::ElementsType::kOnlyNonEditable);
-    }
+    if (document().frame())
+      document().frame()->spellChecker().cancelCheck();

[Xiaocheng, 2017/03/03 18:24:06]

SpellChecker::cancelCheck is not the right function to call; it simply cancels
the pending spell check request, if any. For example, if we:

1. Paste something into an editable, which triggers a spell check request
2. Before the request is resolved, set another editable as non-editable

This patch makes step 2 call SpellChecker::cancelCheck, which simply cancels the
checking for the first editable

     if (adjustedFocusedElementInTreeScope() != this)
       return;
     // The attribute change may cause supportsFocus() to return false
     // for the element which had focus.
     //
     // TODO(tkent): We should avoid updating style.  We'd like to check only
     // DOM-level focusability here.
     document().updateStyleAndLayoutTreeForNode(this);
     if (!supportsFocus())
       blur();
@@ skipping 732 matching lines @@
 
 #ifndef NDEBUG
 
 // For use in the debugger
 void dumpInnerHTML(blink::HTMLElement*);
 
 void dumpInnerHTML(blink::HTMLElement* element) {
   printf("%s\n", element->innerHTML().ascii().data());
 }
 #endif