chromeos: More power-related cleanup.

chrome/browser/chromeos/power/brightness_observer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/power/brightness_observer.h"
 
 #include "ash/shell.h"
-#include "ash/wm/power_button_controller.h"
 #include "chrome/browser/chromeos/login/user_manager.h"
-#include "chrome/browser/extensions/api/system_private/system_private_api.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chromeos/dbus/dbus_thread_manager.h"
 
 namespace chromeos {
 
 BrightnessObserver::BrightnessObserver() {
   DBusThreadManager::Get()->GetPowerManagerClient()->AddObserver(this);
 }
 
 BrightnessObserver::~BrightnessObserver() {
   DBusThreadManager::Get()->GetPowerManagerClient()->RemoveObserver(this);
 }
 
 void BrightnessObserver::BrightnessChanged(int level, bool user_initiated) {
-  extensions::DispatchBrightnessChangedEvent(level, user_initiated);
-  ash::Shell::GetInstance()->power_button_controller()->
-      OnScreenBrightnessChanged(static_cast<double>(level));
-
   // When the user is idle, the power manager dims the screen, turns off the
   // screen and eventually locks the screen (if screen lock on idle and suspend
   // is enabled). For Public Accounts, the session should be terminated instead
   // as soon as the screen turns off.
   // This implementation will be superseded after a revamp of the power manager
   // is complete, see crbug.com/161267.
   if (UserManager::Get()->IsLoggedInAsPublicAccount() &&
       !level && !user_initiated) {
     chrome::AttemptUserExit();

[stevenjb, 2013/10/09 18:52:28]

If we do need this, it seems like we should put the logic in PowerEventObserver
(using LoginState::GetLoggedInUserType), and call
Shell::GetInstance()->system_tray_delegate()->SignOut() (which just calls
chrome::AttemptUserExit()).

While you're in there, SystemTrayDelegate::ShutDown() just calls
ash::Shell::GetInstance()->lock_state_controller()->RequestShutdown(), which
seems kind of silly.

[Daniel Erat, 2013/10/09 19:25:30]

I dunno... I'm still pretty hopeful that this can be deleted now, but if it
can't, it feels like a bit of a stretch to put it in ash. It's very much tied to
public accounts, and I think of those as being a Chrome concept rather than an
Ash concept. 
Just to make sure I understand: you're proposing that
SystemTrayDelegate::ShutDown() be removed and system/date/tray_date.cc just call
LockStateController::RequestShutdown() instead, right?

[stevenjb, 2013/10/09 20:15:36]

1. OK, fair, this is fine here then if we can't remove it.

2. Correct. I'd like to reduce Ash -> Chrome -> Ash calls when there is no
Chrome specific behavior in between. (I'm guessing that this wasn't the case
when first implemented).

[Daniel Erat, 2013/10/09 20:36:39]

(Discussed in person: I'm going to clean this up in a following change.)

   }
 }
 
 }  // namespace chromeos