Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 2669183004: Revert a change to an integer size (Closed)

Created:
3 years, 10 months ago by Kevin Millikin (Google)
Modified:
3 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert a change to an integer size FinalizeHash gets called with values of hashbits that are larger than 32. Fixes #28626. BUG=https://github.com/dart-lang/sdk/issues/28626 R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/392ba729acced757101ef523d9b8a4fe524fce18

Patch Set 1 #

Patch Set 2 : Add a tricky comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/object.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Kevin Millikin (Google)
3 years, 10 months ago (2017-02-03 14:32:36 UTC) #2
Vyacheslav Egorov (Google)
LGTM. Maybe add a comment to avoid a tricky bug here next time?
3 years, 10 months ago (2017-02-03 14:33:49 UTC) #3
Kevin Millikin (Google)
Committed patchset #2 (id:20001) manually as 392ba729acced757101ef523d9b8a4fe524fce18 (presubmit successful).
3 years, 10 months ago (2017-02-03 14:46:43 UTC) #5
Kevin Millikin (Google)
Good idea, a comment was added.
3 years, 10 months ago (2017-02-03 14:51:31 UTC) #6
Florian Schneider
3 years, 10 months ago (2017-02-03 15:38:48 UTC) #7
Message was sent while issue was closed.
Lgtm. Thanks!

Powered by Google App Engine
This is Rietveld 408576698