cc/surfaces/direct_compositor_frame_sink.cc - Issue 2669183002: Seems incorrect to se device_scale_factor in SetLocalSurfaceId.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/surfaces/direct_compositor_frame_sink.cc

Issue 2669183002: Seems incorrect to se device_scale_factor in SetLocalSurfaceId.

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/surfaces/direct_compositor_frame_sink.cc

diff --git a/cc/surfaces/direct_compositor_frame_sink.cc b/cc/surfaces/direct_compositor_frame_sink.cc

index 10c37ee7cc3842ae45d3b48987aead9a936d9612..0bda784934b3f13a8b93d2dd7089494324b89e5e 100644

--- a/cc/surfaces/direct_compositor_frame_sink.cc

+++ b/cc/surfaces/direct_compositor_frame_sink.cc

@@ -93,8 +93,8 @@ void DirectCompositorFrameSink::SubmitCompositorFrame(CompositorFrame frame) {

delegated_local_surface_id_ = surface_id_allocator_.GenerateId();

last_swap_frame_size_ = frame_size;

}

- display_->SetLocalSurfaceId(delegated_local_surface_id_,

- frame.metadata.device_scale_factor);

+ display_->SetLocalSurfaceId(delegated_local_surface_id_);

+ display_->SetDeviceScaleFactor(frame.metadata.device_scale_factor);

factory_.SubmitCompositorFrame(

delegated_local_surface_id_, std::move(frame),