src/parsing/parser.cc - Issue 2669163002: [parser] Skipping inner funcs: produce the same scopes / variables for (some) loops.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parser.cc

Issue 2669163002: [parser] Skipping inner funcs: produce the same scopes / variables for (some) loops. (Closed)

Patch Set: code review (vogelheim@) Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parser.cc

diff --git a/src/parsing/parser.cc b/src/parsing/parser.cc

index d68a212c7ba0a4caa8eb1b24c08cece4b14fb7f0..30b048996869293c2250afdbfe9121813011512e 100644

--- a/src/parsing/parser.cc

+++ b/src/parsing/parser.cc

@@ -2383,7 +2383,6 @@ Statement* Parser::DesugarLexicalBindingsInForStatement(

inner_block->statements()->Add(ignore_completion_block, zone());

}

- inner_scope->set_end_position(scanner()->location().end_pos);

inner_block->set_scope(inner_scope);

}

« no previous file with comments | « no previous file | src/parsing/parser-base.h » ('j') | no next file with comments »