Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js

Issue 2669153003: [MD settings] handle being detached on cr-lazy-render and settings-idle-render
Patch Set: only call render_ once Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js
diff --git a/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js b/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js
index 8fac4f477e294249d0918b6df96d7e831cf571eb..8bae2b672a964300881d635f452c2633a34bdc73 100644
--- a/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js
+++ b/ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js
@@ -43,14 +43,15 @@ Polymer({
/** @private */
render_: function() {
- if (!this.ctor)
- this.templatize(this);
+ // Only initialize once.
+ assert(!this.ctor);
+ // Must have a parent and child in order to add child to parent.
+ assert(this.parentNode && !this.child_);
+ this.templatize(this);
var parentNode = this.parentNode;
- if (parentNode && !this.child_) {
- var instance = this.stamp({});
- this.child_ = instance.root.firstElementChild;
- parentNode.insertBefore(instance.root, this);
- }
+ var instance = this.stamp({});
+ this.child_ = instance.root.firstElementChild;
+ parentNode.insertBefore(instance.root, this);
},
/**

Powered by Google App Engine
This is Rietveld 408576698