Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2306)

Unified Diff: chrome/browser/resources/settings/controls/settings_idle_render.js

Issue 2669153003: [MD settings] handle being detached on cr-lazy-render and settings-idle-render
Patch Set: handling get() when detached Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/controls/settings_idle_render.js
diff --git a/chrome/browser/resources/settings/controls/settings_idle_render.js b/chrome/browser/resources/settings/controls/settings_idle_render.js
index 8e224c9e5414b54437e08f556a7411fdbb2a9868..44fc1d3f990090f91d1908c5b654c3cf83faf05e 100644
--- a/chrome/browser/resources/settings/controls/settings_idle_render.js
+++ b/chrome/browser/resources/settings/controls/settings_idle_render.js
@@ -30,6 +30,7 @@ Polymer({
/** @override */
detached: function() {
+ this.child_ = null;
Dan Beam 2017/02/11 23:01:35 but wait, does this mean it could get double-rende
tsergeant 2017/02/15 06:31:39 Yeah, if you detach the settings-idle-render, its
// No-op if callback already fired.
cancelIdleCallback(this.idleCallback_);
},
« no previous file with comments | « no previous file | ui/webui/resources/cr_elements/cr_lazy_render/cr_lazy_render.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698