Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1498)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.cc

Issue 2669133003: Update AddToHomescreenDataFetcher to accept badge icon for WebAPK. (Closed)
Patch Set: Format Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_manager.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.cc b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
index ddfa514fc8dc3048dab65afd25409693f86e33d7..30ba4e661d37edba842a8ae6f9127a92b6dc70e5 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_manager.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
@@ -88,6 +88,8 @@ void AddToHomescreenManager::Start(content::WebContents* web_contents) {
ShortcutHelper::GetMinimumHomescreenIconSizeInPx(),
ShortcutHelper::GetIdealSplashImageSizeInPx(),
ShortcutHelper::GetMinimumSplashImageSizeInPx(),
+ ShortcutHelper::GetIdealBadgeIconSizeInPx(),
+ ShortcutHelper::GetIdealBadgeIconSizeInPx(),
check_webapk_compatible, this);
}
@@ -163,8 +165,10 @@ void AddToHomescreenManager::OnUserTitleAvailable(
}
void AddToHomescreenManager::OnDataAvailable(const ShortcutInfo& info,
- const SkBitmap& icon) {
+ const SkBitmap& icon,
+ const SkBitmap& badge) {
if (is_webapk_compatible_) {
+ // TODO(zpeng): Add badge to WebAPK installation flow.
WebApkInstallService* install_service =
WebApkInstallService::Get(
data_fetcher_->web_contents()->GetBrowserContext());

Powered by Google App Engine
This is Rietveld 408576698