Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 266913019: Ensure that _GNU_SOURCE is defined early enough (Closed)

Created:
6 years, 7 months ago by Mostyn Bramley-Moore
Modified:
6 years, 7 months ago
CC:
chromium-reviews, agl, jln+watch_chromium.org
Visibility:
Public.

Description

Ensure that _GNU_SOURCE is defined early enough This style cleanup broke some versions of glibc that include fcntl.h from another header before it is explicitly included: https://codereview.chromium.org/236083002/ We need _GNU_SOURCE defined before the first time fcntl.h is included since we use the linux-specific O_DIRECTORY extension. Thanks to johan_e@opera.com for helping track this down. NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269419

Patch Set 1 #

Patch Set 2 : add a better comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M sandbox/linux/suid/linux_util.c View 1 1 chunk +5 lines, -2 lines 0 comments Download
M sandbox/linux/suid/process_util_linux.c View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
Mostyn Bramley-Moore
@jln, rsesek: PTAL at this fixup.
6 years, 7 months ago (2014-05-06 09:33:56 UTC) #1
jln (very slow on Chromium)
Thanks, lgtm!
6 years, 7 months ago (2014-05-08 00:50:44 UTC) #2
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 7 months ago (2014-05-08 07:11:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/266913019/20001
6 years, 7 months ago (2014-05-08 07:13:29 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-08 20:27:20 UTC) #5
Mostyn Bramley-Moore
The CQ bit was unchecked by mostynb@opera.com
6 years, 7 months ago (2014-05-08 20:49:44 UTC) #6
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 7 months ago (2014-05-08 20:49:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/266913019/20001
6 years, 7 months ago (2014-05-08 20:52:32 UTC) #8
Mostyn Bramley-Moore
The CQ bit was unchecked by mostynb@opera.com
6 years, 7 months ago (2014-05-08 22:31:51 UTC) #9
Mostyn Bramley-Moore
This CL only touches *_linux.cc files, and is being blocked in the CQ due to ...
6 years, 7 months ago (2014-05-08 22:33:42 UTC) #10
Mostyn Bramley-Moore
The CQ bit was checked by mostynb@opera.com
6 years, 7 months ago (2014-05-08 22:33:47 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mostynb@opera.com/266913019/20001
6 years, 7 months ago (2014-05-08 22:39:20 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 21:41:05 UTC) #13
Message was sent while issue was closed.
Change committed as 269419

Powered by Google App Engine
This is Rietveld 408576698