google_apis/gcm/gcm_client_impl_unittest.cc - Issue 266913015: Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: google_apis/gcm/gcm_client_impl_unittest.cc

Issue 266913015: Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing Jian's comments. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« google_apis/gcm/gcm_client.h ('K') | « google_apis/gcm/gcm_client_impl.cc ('k') | google_apis/gcm/monitoring/gcm_stats_recorder.h » ('j') | google_apis/gcm/monitoring/gcm_stats_recorder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: google_apis/gcm/gcm_client_impl_unittest.cc

diff --git a/google_apis/gcm/gcm_client_impl_unittest.cc b/google_apis/gcm/gcm_client_impl_unittest.cc

index 451c2c40b10cf6e3de03aae64e9c71aad116017a..2c5e78d2f9f05f5bf0972e12b73a6516b32ad26a 100644

--- a/google_apis/gcm/gcm_client_impl_unittest.cc

+++ b/google_apis/gcm/gcm_client_impl_unittest.cc

@@ -250,6 +250,7 @@ class GCMClientImplTest : public testing::Test,

const std::string& app_id,

const gcm::GCMClient::SendErrorDetails& send_error_details) OVERRIDE;

virtual void OnGCMReady() OVERRIDE;

+ virtual void OnActivityRecorded() OVERRIDE {}

GCMClientImpl* gcm_client() const { return gcm_client_.get(); }

FakeMCSClient* mcs_client() const {