Enable auto-refreshing of the gcm-internals page whenever a GCM activity is recorded.

chrome/browser/services/gcm/gcm_service.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/services/gcm/gcm_service.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 128 matching lines @@
                               const std::string& message_id,
                               GCMClient::Result result) OVERRIDE;
   virtual void OnMessageReceived(
       const std::string& app_id,
       const GCMClient::IncomingMessage& message) OVERRIDE;
   virtual void OnMessagesDeleted(const std::string& app_id) OVERRIDE;
   virtual void OnMessageSendError(
       const std::string& app_id,
       const GCMClient::SendErrorDetails& send_error_details) OVERRIDE;
   virtual void OnGCMReady() OVERRIDE;
+  virtual void OnActivityRecorded() OVERRIDE;
 
   // Called on IO thread.
   void Initialize(scoped_ptr<GCMClientFactory> gcm_client_factory,
                   const base::FilePath& store_path,
                   const std::vector<std::string>& account_ids,
                   const scoped_refptr<net::URLRequestContextGetter>&
                       url_request_context_getter);
   void Load(const base::WeakPtr<GCMService>& service);
   void Stop();
   void CheckOut();
   void Register(const std::string& app_id,
                 const std::vector<std::string>& sender_ids);
   void Unregister(const std::string& app_id);
   void Send(const std::string& app_id,
             const std::string& receiver_id,
             const GCMClient::OutgoingMessage& message);
   void GetGCMStatistics(bool clear_logs);
   void SetGCMRecording(bool recording);
 
   // For testing purpose. Can be called from UI thread. Use with care.
   GCMClient* gcm_client_for_testing() const { return gcm_client_.get(); }
 
  private:
+  // Do the actual work of fetching GCM stats from GCM client and post back.
+  void DoGetGCMStatistics();
+
   base::WeakPtr<GCMService> service_;
 
   scoped_ptr<GCMClient> gcm_client_;
 
   DISALLOW_COPY_AND_ASSIGN(IOWorker);
 };
 
 GCMService::IOWorker::IOWorker() {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
 }
@@ skipping 107 matching lines @@
                                               send_error_details));
 }
 
 void GCMService::IOWorker::OnGCMReady() {
   content::BrowserThread::PostTask(content::BrowserThread::UI,
                                    FROM_HERE,
                                    base::Bind(&GCMService::GCMClientReady,
                                               service_));
 }
 
+void GCMService::IOWorker::OnActivityRecorded() {
+  DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
+  // When an activity is recorded, get all the stats and refresh the UI of
+  // gcm-internals page.
+  DoGetGCMStatistics();

[jianli, 2014/05/06 22:54:53]

Why not just calleding GetGCMStatistics with false value?

[juyik, 2014/05/07 00:07:48]

Done.

+}
+
 void GCMService::IOWorker::Load(const base::WeakPtr<GCMService>& service) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
 
   service_ = service;
   gcm_client_->Load();
 }
 
 void GCMService::IOWorker::Stop() {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
 
@@ skipping 26 matching lines @@
 void GCMService::IOWorker::Send(const std::string& app_id,
                                 const std::string& receiver_id,
                                 const GCMClient::OutgoingMessage& message) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
 
   gcm_client_->Send(app_id, receiver_id, message);
 }
 
 void GCMService::IOWorker::GetGCMStatistics(bool clear_logs) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));
-  gcm::GCMClient::GCMStatistics stats;
 
   if (gcm_client_.get()) {

[jianli, 2014/05/06 22:54:53]

It seems that there is behavior change when gcm_client_ is empty:
GCMService::GetGCMStatisticsFinished is not called.

[juyik, 2014/05/07 00:07:48]

Done.

     if (clear_logs)
       gcm_client_->ClearActivityLogs();
+    DoGetGCMStatistics();
+  }
+}
+
+void GCMService::IOWorker::DoGetGCMStatistics() {
+  gcm::GCMClient::GCMStatistics stats;
+
+  if (gcm_client_.get()) {

[jianli, 2014/05/06 22:54:53]

nit: brackets not needed

[juyik, 2014/05/07 00:07:48]

Done.

     stats = gcm_client_->GetStatistics();
   }
 
   content::BrowserThread::PostTask(
       content::BrowserThread::UI,
       FROM_HERE,
       base::Bind(&GCMService::GetGCMStatisticsFinished, service_, stats));
 }
 
 void GCMService::IOWorker::SetGCMRecording(bool recording) {
@@ skipping 481 matching lines @@
   return iter == app_handlers_.end() ? &default_app_handler_ : iter->second;
 }
 
 void GCMService::GetGCMStatisticsFinished(
     GCMClient::GCMStatistics stats) {
   DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
   request_gcm_statistics_callback_.Run(stats);
 }
 
 }  // namespace gcm