Refactor 'dart:profiler' UserTag API

runtime/vm/intrinsifier_mips.cc

Index: runtime/vm/intrinsifier_mips.cc
diff --git a/runtime/vm/intrinsifier_mips.cc b/runtime/vm/intrinsifier_mips.cc
index 263514dbe2f24101a093665e86f5aca7a7ce7277..19c0baae329a435e2a2fccf89a3f78a9d57e4769 100644
--- a/runtime/vm/intrinsifier_mips.cc
+++ b/runtime/vm/intrinsifier_mips.cc
@@ -1783,6 +1783,8 @@ void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) {
   // T1: Isolate.
   Isolate* isolate = Isolate::Current();
   __ LoadImmediate(T1, reinterpret_cast<uword>(isolate));
+  // T2: Current user tag.
+  __ lw(T2, Address(T1, Isolate::current_tag_offset()));

[zra, 2014/05/06 15:27:24]

Same here.

[Cutch, 2014/05/06 17:00:25]

Done.

   // V0: UserTag.
   __ lw(V0, Address(SP, + 0 * kWordSize));
   // Set Isolate::current_tag_.
@@ -1793,33 +1795,28 @@ void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) {
   __ sw(V0, Address(T1, Isolate::user_tag_offset()));
   // Set return value.
   __ Ret();
-  __ delay_slot()->LoadImmediate(V0, reinterpret_cast<int32_t>(Object::null()));

[Ivan Posva, 2014/05/06 16:43:06]

Zach, can you please make sure this is not allowed?

+  __ delay_slot()->mov(V0, T2);
 }
 
 
-void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
-  // V0: Isolate.
+void Intrinsifier::UserTag_defaultTag(Assembler* assembler) {
   Isolate* isolate = Isolate::Current();
-  __ LoadImmediate(V0, reinterpret_cast<uword>(isolate));
-  // Set return value.
+  // V0: Address of default tag.
+  __ LoadImmediate(V0,
+      reinterpret_cast<uword>(isolate->object_store()) +
+                              ObjectStore::default_tag_offset());
   __ Ret();
-  __ delay_slot()->lw(V0, Address(V0, Isolate::current_tag_offset()));
+  __ delay_slot()->lw(V0, Address(V0, 0));
 }
 
 
-void Intrinsifier::Profiler_clearCurrentTag(Assembler* assembler) {
-  // T1: Isolate.
+void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
+  // V0: Isolate.
   Isolate* isolate = Isolate::Current();
-  __ LoadImmediate(T1, reinterpret_cast<uword>(isolate));
-  // Set return value to Isolate::current_tag_.
-  __ lw(V0, Address(T1, Isolate::current_tag_offset()));
-  // Clear Isolate::current_tag_.
-  const int32_t raw_null = reinterpret_cast<int32_t>(UserTag::null());
-  __ LoadImmediate(T0, raw_null);
-  __ sw(T0, Address(T1, Isolate::current_tag_offset()));
-  // Clear Isolate::user_tag_.
+  __ LoadImmediate(V0, reinterpret_cast<uword>(isolate));
+  // Set return value.
   __ Ret();
-  __ delay_slot()->sw(ZR, Address(T1, Isolate::user_tag_offset()));
+  __ delay_slot()->lw(V0, Address(V0, Isolate::current_tag_offset()));
 }
 
 }  // namespace dart