Refactor 'dart:profiler' UserTag API

runtime/vm/intrinsifier_arm.cc

Index: runtime/vm/intrinsifier_arm.cc
diff --git a/runtime/vm/intrinsifier_arm.cc b/runtime/vm/intrinsifier_arm.cc
index 69dd6470a9ab40bbee7c7e8ba9d5b9d23e1cab1a..b27e7c6f00a9d813d1b24f0e3c22da2b14a31b82 100644
--- a/runtime/vm/intrinsifier_arm.cc
+++ b/runtime/vm/intrinsifier_arm.cc
@@ -1723,6 +1723,8 @@ void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) {
   // R1: Isolate.
   Isolate* isolate = Isolate::Current();
   __ LoadImmediate(R1, reinterpret_cast<uword>(isolate));
+  // R2: Current user tag.
+  __ ldr(R2, Address(R1, Isolate::current_tag_offset()));

[zra, 2014/05/06 15:27:24]

Could you load this directly into R0, and get rid of the mov into R0 before the
return?

[Cutch, 2014/05/06 17:00:25]

Done.

   // R0: UserTag.
   __ ldr(R0, Address(SP, + 0 * kWordSize));
   // Set Isolate::current_tag_.
@@ -1732,35 +1734,28 @@ void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) {
   // Set Isolate::user_tag_.
   __ str(R0, Address(R1, Isolate::user_tag_offset()));
   // Set return value.
-  const int32_t raw_null = reinterpret_cast<int32_t>(Object::null());
-  __ LoadImmediate(R0, raw_null);
+  __ mov(R0, ShifterOperand(R2));
   __ Ret();
 }
 
 
-void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
-  // R1: Isolate.
+void Intrinsifier::UserTag_defaultTag(Assembler* assembler) {
   Isolate* isolate = Isolate::Current();
-  __ LoadImmediate(R1, reinterpret_cast<uword>(isolate));
-  // Set return value to Isolate::current_tag_.
-  __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
+  // Set return value to default tag address.
+  __ LoadImmediate(R0,
+      reinterpret_cast<uword>(isolate->object_store()) +
+                              ObjectStore::default_tag_offset());
+  __ ldr(R0, Address(R0, 0));
   __ Ret();
 }
 
 
-void Intrinsifier::Profiler_clearCurrentTag(Assembler* assembler) {
-  // R1: Isolate.
+void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
+  // R1: Default tag address.
   Isolate* isolate = Isolate::Current();
   __ LoadImmediate(R1, reinterpret_cast<uword>(isolate));
   // Set return value to Isolate::current_tag_.
   __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
-  // Clear Isolate::current_tag_.
-  const int32_t raw_null = reinterpret_cast<int32_t>(UserTag::null());
-  __ LoadImmediate(R2, raw_null);
-  __ str(R2, Address(R1, Isolate::current_tag_offset()));
-  // Clear Isolate::user_tag_.
-  __ eor(R2, R2, ShifterOperand(R2));
-  __ str(R2, Address(R1, Isolate::user_tag_offset()));
   __ Ret();
 }