iOS: Mark HTTP pages with credit card fields with an omnibox icon.

ios/web/public/web_state/web_state.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_
 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_
 
 #include <stdint.h>
 
 #include <string>
@@ skipping 195 matching lines @@
   // Returns true if a WebInterstitial is currently displayed.
   virtual bool IsShowingWebInterstitial() const = 0;
 
   // Returns the currently visible WebInterstitial if one is shown.
   virtual WebInterstitial* GetWebInterstitial() const = 0;
 
   // Tells the WebState that the current page is an HTTP page
   // containing a password field.
   virtual void OnPasswordInputShownOnHttp() = 0;
 
+  // Tells the WebState that the current page is an HTTP page

[Eugene But (OOO till 7-30), 2017/02/03 19:24:16]

Do you want to use comment from web contents which looks more informative?
https://cs.chromium.org/chromium/src/content/public/browser/web_contents.h?ty...

If so, could you please update OnPasswordInputShownOnHttp comment as well.

[lgarron, 2017/02/04 00:28:35]

I'd rather be a little more general here, in case the functionality needs to
change a little bit. Is that okay?

[Eugene But (OOO till 7-30), 2017/02/04 01:29:17]

It's ok, but how is this code different from content? If this comment is better
then maybe comments in content should be updated? Generally this is up to you.

+  // containing a credit card field.
+  virtual void OnCreditCardInputShownOnHttp() = 0;
+
   // Callback used to handle script commands.
   // The callback must return true if the command was handled, and false
   // otherwise.
   // In particular the callback must return false if the command is unexpected
   // or ill-formatted.
   // The first parameter is the content of the command, the second parameter is
   // the URL of the page, and the third parameter is a bool indicating if the
   // user is currently interacting with the page.
   typedef base::Callback<bool(const base::DictionaryValue&, const GURL&, bool)>
       ScriptCommandCallback;
@@ skipping 55 matching lines @@
 
   // Returns a WeakPtr<WebState> to the current WebState. Must remain private
   // and only call must be in WebStateWeakPtrFactory. Please consult that class
   // for more details. Remove as part of http://crbug.com/556736.
   virtual base::WeakPtr<WebState> AsWeakPtr() = 0;
 };
 
 }  // namespace web
 
 #endif  // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_H_