Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2669103003: Add Selection.toString() calling the native method (Closed)

Created:
3 years, 10 months ago by Alan Knight
Modified:
3 years, 10 months ago
Reviewers:
terry
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add Selection.toString() calling the native method BUG= R=terry@google.com Committed: https://github.com/dart-lang/sdk/commit/01e6e00499f686c7eaac21cfffe1c3cd6f8b7bf5

Patch Set 1 #

Patch Set 2 : Add Selection.toString() #

Patch Set 3 : Merged in previous impl_Selection template #

Patch Set 4 : Previous merge was a mistake, undoing #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -43 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 2 chunks +7 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 27 chunks +0 lines, -27 lines 0 comments Download
M tools/dom/scripts/systemhtml.py View 1 chunk +1 line, -0 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_Selection.darttemplate View 1 3 1 chunk +9 lines, -12 lines 1 comment Download

Messages

Total messages: 5 (2 generated)
Alan Knight
https://codereview.chromium.org/2669103003/diff/60001/tools/dom/templates/html/impl/impl_Selection.darttemplate File tools/dom/templates/html/impl/impl_Selection.darttemplate (left): https://codereview.chromium.org/2669103003/diff/60001/tools/dom/templates/html/impl/impl_Selection.darttemplate#oldcode7 tools/dom/templates/html/impl/impl_Selection.darttemplate:7: $if DARTIUM Note: this is bogus. The file is ...
3 years, 10 months ago (2017-02-03 18:06:37 UTC) #2
terry
lgtm
3 years, 10 months ago (2017-02-03 18:16:08 UTC) #3
Alan Knight
3 years, 10 months ago (2017-02-03 18:24:23 UTC) #5
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
01e6e00499f686c7eaac21cfffe1c3cd6f8b7bf5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698