Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 2669073002: MD Settings: Allow controlled-button to be used with icons. (Closed)
Patch Set: have the parent row of the controlled-button disable/enable based on controlled-button state Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/downloads_page/downloads_page.html
diff --git a/chrome/browser/resources/settings/downloads_page/downloads_page.html b/chrome/browser/resources/settings/downloads_page/downloads_page.html
index 64af1e7a93b9f7e9c60d505dc199c1b2a5b38be8..47e990740a474d3aea8d2c352a43f4f625ce85da 100644
--- a/chrome/browser/resources/settings/downloads_page/downloads_page.html
+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.html
@@ -6,8 +6,13 @@
<dom-module id="settings-downloads-page">
<template>
- <style include="settings-shared"></style>
- <div class="settings-box first two-line">
+ <style include="settings-shared">
+ .settings-box[disabled] {
+ pointer-events: none;
+ }
+ </style>
+ <div class="settings-box first two-line" on-tap="selectDownloadLocation_"
+ disabled$="[[isControlled_]]" actionable>
<div class="start">
<div>$i18n{downloadLocation}</div>
<div class="secondary">
@@ -19,14 +24,10 @@
</if>
</div>
</div>
- <div class="secondary-action">
- <controlled-button class="secondary-button" id="changeDownloadsPath"
- on-tap="selectDownloadLocation_"
- pref="[[prefs.download.default_directory]]"
- end-justified>
- $i18n{changeDownloadLocation}
- </controlled-button>
- </div>
+ <controlled-button id="changeDownloadsPath" icon-class="icon-external"
+ pref="[[prefs.download.default_directory]]" end-justified
+ controlled="{{isControlled_}}">
+ </controlled-button>
</div>
<div class="settings-box block">
<settings-toggle-button

Powered by Google App Engine
This is Rietveld 408576698