Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Unified Diff: chrome/browser/resources/settings/controls/controlled_button.js

Issue 2669073002: MD Settings: Allow controlled-button to be used with icons. (Closed)
Patch Set: have the parent row of the controlled-button disable/enable based on controlled-button state Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/controls/controlled_button.js
diff --git a/chrome/browser/resources/settings/controls/controlled_button.js b/chrome/browser/resources/settings/controls/controlled_button.js
index d1b97231b589064ca4a4d9aa74c0da9445c3a6aa..947d8b6c15c89d7ff2dbccbb055254129afea013 100644
--- a/chrome/browser/resources/settings/controls/controlled_button.js
+++ b/chrome/browser/resources/settings/controls/controlled_button.js
@@ -18,11 +18,23 @@ Polymer({
reflectToAttribute: true,
},
+ /**
+ * This attribute takes in a class-name to form an icon button instead of
+ * a paper-button. Note that if this attribute is present, the light dom
+ * content will be ignored.
+ */
+ iconClass: {
+ type: String,
+ value: null,
+ reflectToAttribute: true,
+ },
+
/** @private */
- controlled_: {
+ controlled: {
type: Boolean,
computed: 'computeControlled_(pref.*)',
reflectToAttribute: true,
+ notify: true
},
},

Powered by Google App Engine
This is Rietveld 408576698