chrome/browser/resources/settings/downloads_page/downloads_page.html - Issue 2669073002: MD Settings: Allow controlled-button to be used with icons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/downloads_page/downloads_page.html

Issue 2669073002: MD Settings: Allow controlled-button to be used with icons. (Closed)

Patch Set: add comment about iconClass Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/controls/controlled_button.html ('K') | « chrome/browser/resources/settings/controls/controlled_button.js ('k') | chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/downloads_page/downloads_page.html

diff --git a/chrome/browser/resources/settings/downloads_page/downloads_page.html b/chrome/browser/resources/settings/downloads_page/downloads_page.html

index 64af1e7a93b9f7e9c60d505dc199c1b2a5b38be8..61bfc66a612f0b3e73d4e8f3062e70b9bf51767c 100644

--- a/chrome/browser/resources/settings/downloads_page/downloads_page.html

+++ b/chrome/browser/resources/settings/downloads_page/downloads_page.html

@@ -19,14 +19,11 @@

</if>

</div>

- <div class="secondary-action">

- <controlled-button class="secondary-button" id="changeDownloadsPath"

- on-tap="selectDownloadLocation_"

- pref="[[prefs.download.default_directory]]"

- end-justified>

- $i18n{changeDownloadLocation}

- </controlled-button>

- </div>

+ <controlled-button id="changeDownloadsPath" icon-class="icon-external"

+ on-tap="selectDownloadLocation_"

+ pref="[[prefs.download.default_directory]]"

+ end-justified>

+ </controlled-button>

</div>

<settings-toggle-button