Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: recipe_engine/config_types.py

Issue 2669033007: [recipe_engine] Fix a couple path-related bugs. (Closed)
Patch Set: Fix remainder of presubmit tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | recipe_engine/doc.py » ('j') | recipe_engine/doc.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: recipe_engine/config_types.py
diff --git a/recipe_engine/config_types.py b/recipe_engine/config_types.py
index b7a2705e77c25ed5750db2e76d8ee5e94c4cceed..87feebe6c31071d18e616d0b141b87f7ddc65b51 100644
--- a/recipe_engine/config_types.py
+++ b/recipe_engine/config_types.py
@@ -178,6 +178,8 @@ class Path(RecipeConfigType):
return not self.base == other
def join(self, *pieces, **kwargs):
+ if not pieces and not kwargs:
+ return self
kwargs.setdefault('platform_ext', self.platform_ext)
return Path(self.base, *filter(bool, self.pieces + pieces), **kwargs)
« no previous file with comments | « no previous file | recipe_engine/doc.py » ('j') | recipe_engine/doc.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698