[recipe_engine] Fix a couple path-related bugs.

recipe_engine/doc.py

 #!/usr/bin/env python
 # Copyright 2013 The LUCI Authors. All rights reserved.
 # Use of this source code is governed under the Apache License, Version 2.0
 # that can be found in the LICENSE file.
 
 from __future__ import print_function
 
 import collections
 import inspect
 import os
@@ skipping 83 matching lines @@
   for method in sorted(common_methods):
     pmethod(1, method, getattr(recipe_api.RecipeApi, method))
 
   deps = {}
   universe = universe_view.universe
   for module_name in universe_view.loop_over_recipe_modules():
     deps[module_name] = universe.load(universe_view.package, module_name)
 
   inst = loader.create_recipe_api(
       universe.package_deps.root_package,
-      deps, "fake_doc_recipe.py", recipe_run.RecipeEngine(None, {}, universe))
+      deps, "fake_doc_recipe.py", recipe_run.RecipeEngine(
+        None, {}, universe_view))

[iannucci, 2017/02/03 00:00:05]

So... this has always been wrong and just miraculously worked before. The engine
is supposed to take the universe_view, not the universe...

 
   for mod_name, mod in sorted(deps.iteritems(), key=lambda it: it[0]):
     p(0)
     p(0, "(%s) -- %s" % (mod_name, mod.__path__[0]))
     if mod.LOADED_DEPS:
       p(1, 'DEPS:', list(mod.LOADED_DEPS))
 
     subinst = getattr(inst, mod_name)
     bases = set(subinst.__class__.__bases__)
     base_fns = set()
     for base in bases:
       for name, _ in inspect.getmembers(base):
         base_fns.add(name)
     for cool_base in bases - set((recipe_api.RecipeApi,)):
       p(1, 'behaves like %s' % map_to_cool_name(cool_base))
 
     if mod.API.__doc__:
       for line in trim_doc(mod.API.__doc__):
         p(2, '"', line)
 
     for fn_name, obj in member_iter(subinst):
       if fn_name in base_fns:
         continue
       pmethod(1, fn_name, obj)