Optimize outline paint invalidation

third_party/WebKit/Source/core/layout/LayoutObject.h

 /*
  * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
  *           (C) 2000 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Dirk Mueller (mueller@kde.org)
  *           (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
  * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
  *               All rights reserved.
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 1731 matching lines @@
     }
     void setHasPreviousSelectionVisualRect(bool b) {
       m_layoutObject.m_bitfields.setHasPreviousSelectionVisualRect(b);
     }
     void setHasPreviousBoxGeometries(bool b) {
       m_layoutObject.m_bitfields.setHasPreviousBoxGeometries(b);
     }
     void setPreviousBackgroundObscured(bool b) {
       m_layoutObject.setPreviousBackgroundObscured(b);
     }
+    void updatePreviousOutlineMayBeAffectedByDescendants() {
+      m_layoutObject.setPreviousOutlineMayBeAffectedByDescendants(
+          m_layoutObject.outlineMayBeAffectedByDescendants());
+    }
 
     void clearPreviousVisualRects() {
       m_layoutObject.clearPreviousVisualRects();
     }
     void setNeedsPaintPropertyUpdate() {
       m_layoutObject.setNeedsPaintPropertyUpdate();
     }
+
 #if DCHECK_IS_ON()
     // Same as setNeedsPaintPropertyUpdate() but does not mark ancestors as
     // having a descendant needing a paint property update.
     void setOnlyThisNeedsPaintPropertyUpdateForTesting() {
       m_layoutObject.m_bitfields.setNeedsPaintPropertyUpdate(true);
     }
     void clearNeedsPaintPropertyUpdateForTesting() {
       m_layoutObject.m_bitfields.setNeedsPaintPropertyUpdate(false);
     }
 #endif
@@ skipping 95 matching lines @@
     return m_bitfields.hasPreviousBoxGeometries();
   }
 
   bool backgroundChangedSinceLastPaintInvalidation() const {
     return m_bitfields.backgroundChangedSinceLastPaintInvalidation();
   }
   void setBackgroundChangedSinceLastPaintInvalidation() {
     m_bitfields.setBackgroundChangedSinceLastPaintInvalidation(true);
   }
 
+  bool outlineMayBeAffectedByDescendants() const {
+    return m_bitfields.outlineMayBeAffectedByDescendants();
+  }
+  bool previousOutlineMayBeAffectedByDescendants() const {
+    return m_bitfields.previousOutlineMayBeAffectedByDescendants();
+  }
+
  protected:
   enum LayoutObjectType {
     LayoutObjectBr,
     LayoutObjectCanvas,
     LayoutObjectFieldset,
     LayoutObjectCounter,
     LayoutObjectDetailsMarker,
     LayoutObjectEmbeddedObject,
     LayoutObjectFileUploadControl,
     LayoutObjectFrame,
@@ skipping 158 matching lines @@
   // LayoutFlowThread.
   void removeFromLayoutFlowThread();
 
   bool containsInlineWithOutlineAndContinuation() const {
     return m_bitfields.containsInlineWithOutlineAndContinuation();
   }
   void setContainsInlineWithOutlineAndContinuation(bool b) {
     m_bitfields.setContainsInlineWithOutlineAndContinuation(b);
   }
 
+  void setOutlineMayBeAffectedByDescendants(bool b) {
+    m_bitfields.setOutlineMayBeAffectedByDescendants(b);
+  }
+  void setPreviousOutlineMayBeAffectedByDescendants(bool b) {
+    m_bitfields.setPreviousOutlineMayBeAffectedByDescendants(b);
+  }
+
  private:
   // Adjusts a visual rect in the space of |m_previousVisualRect| to be in the
   // space of the |paintInvalidationContainer|, if needed. They can be different
   // only if |paintInvalidationContainer| is a composited scroller.
   void adjustVisualRectForCompositedScrolling(
       LayoutRect&,
       const LayoutBoxModelObject& paintInvalidationContainer) const;
 
   FloatQuad localToAncestorQuadInternal(const FloatQuad&,
                                         const LayoutBoxModelObject* ancestor,
@@ skipping 146 matching lines @@
           m_isScrollAnchorObject(false),
           m_scrollAnchorDisablingStyleChanged(false),
           m_hasBoxDecorationBackground(false),
           m_hasPreviousLocationInBacking(false),
           m_hasPreviousSelectionVisualRect(false),
           m_hasPreviousBoxGeometries(false),
           m_needsPaintPropertyUpdate(true),
           m_subtreeNeedsPaintPropertyUpdate(true),
           m_descendantNeedsPaintPropertyUpdate(true),
           m_backgroundChangedSinceLastPaintInvalidation(false),
+          m_outlineMayBeAffectedByDescendants(false),
+          m_previousOutlineMayBeAffectedByDescendants(false),
           m_positionedState(IsStaticallyPositioned),
           m_selectionState(SelectionNone),
           m_backgroundObscurationState(BackgroundObscurationStatusInvalid),
           m_fullPaintInvalidationReason(PaintInvalidationNone) {}
 
     // Self needs layout means that this layout object is marked for a full
     // layout. This is the default layout but it is expensive as it recomputes
     // everything. For CSS boxes, this includes the width (laying out the line
     // boxes again), the margins (due to block collapsing margins), the
     // positions, the height and the potential overflow.
@@ skipping 162 matching lines @@
     ADD_BOOLEAN_BITFIELD(subtreeNeedsPaintPropertyUpdate,
                          SubtreeNeedsPaintPropertyUpdate)
     // Whether the paint properties of a descendant need to be updated. For more
     // details, see LayoutObject::descendantNeedsPaintPropertyUpdate().
     ADD_BOOLEAN_BITFIELD(descendantNeedsPaintPropertyUpdate,
                          DescendantNeedsPaintPropertyUpdate);
 
     ADD_BOOLEAN_BITFIELD(backgroundChangedSinceLastPaintInvalidation,
                          BackgroundChangedSinceLastPaintInvalidation);
 
+    // Whether shape of outline may be affected by any descendants. This is
+    // updated before paint invalidation, checked during paint invalidation.
+    ADD_BOOLEAN_BITFIELD(outlineMayBeAffectedByDescendants,
+                         OutlineMayBeAffectedByDescendants);
+    // The outlineMayBeAffectedByDescendants status of the last paint
+    // invalidation.
+    ADD_BOOLEAN_BITFIELD(previousOutlineMayBeAffectedByDescendants,
+                         PreviousOutlineMayBeAffectedByDescendants);
+
    protected:
     // Use protected to avoid warning about unused variable.
-    unsigned m_unusedBits : 6;
+    unsigned m_unusedBits : 4;
 
    private:
     // This is the cached 'position' value of this object
     // (see ComputedStyle::position).
     unsigned m_positionedState : 2;  // PositionedState
     unsigned m_selectionState : 3;   // SelectionState
     // Mutable for getter which lazily update this field.
     mutable unsigned
         m_backgroundObscurationState : 2;        // BackgroundObscurationState
     unsigned m_fullPaintInvalidationReason : 5;  // PaintInvalidationReason
@@ skipping 327 matching lines @@
 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
 // We don't make object2 an optional parameter so that showLayoutTree
 // can be called from gdb easily.
 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
                                 const blink::LayoutObject* object2);
 
 #endif
 
 #endif  // LayoutObject_h