components/ntp_tiles/most_visited_sites.cc - Issue 2668943002: provide static popular sites for first run

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_tiles/most_visited_sites.cc

Issue 2668943002: provide static popular sites for first run (Closed)

Patch Set: Remove unnecessary rebuild. Fix tests. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_tiles/most_visited_sites.cc

diff --git a/components/ntp_tiles/most_visited_sites.cc b/components/ntp_tiles/most_visited_sites.cc

index ca75d4c77cd7a01006ebc850b30225b43ca05d70..7106f08f70c45c7acd3c881caf61b6565d8fd3ae 100644

--- a/components/ntp_tiles/most_visited_sites.cc

+++ b/components/ntp_tiles/most_visited_sites.cc

@@ -419,9 +419,6 @@ void MostVisitedSites::OnPopularSitesDownloaded(bool success) {

LOG(WARNING) << "Download of popular sites failed";

return;

}

- // Re-build the tile list. Once done, this will notify the observer.

- BuildCurrentTiles();

}

void MostVisitedSites::OnIconMadeAvailable(const GURL& site_url,